<html>
<head><meta charset="utf-8"><title>removing-locations-all · t-compiler/wg-nll · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/index.html">t-compiler/wg-nll</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/removing-locations-all.html">removing-locations-all</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="126988078"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/removing-locations-all/near/126988078" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/removing-locations-all.html#126988078">(May 23 2018 at 17:54)</a>:</h4>
<p>So I have this PR that I want to land:</p>
<p><a href="https://github.com/rust-lang/rust/pull/50938" target="_blank" title="https://github.com/rust-lang/rust/pull/50938">https://github.com/rust-lang/rust/pull/50938</a></p>
<p>However, it currently generates an ICE. I could use some help to dig into it, maybe?</p>



<a name="126988091"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/removing-locations-all/near/126988091" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/removing-locations-all.html#126988091">(May 23 2018 at 17:55)</a>:</h4>
<p>Though actually as a very first step, we could just run <em>with this PR</em> to regenerate facts</p>



<a name="126988097"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/removing-locations-all/near/126988097" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/removing-locations-all.html#126988097">(May 23 2018 at 17:55)</a>:</h4>
<p>and feed those into polonius</p>



<a name="126988226"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/removing-locations-all/near/126988226" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/removing-locations-all.html#126988226">(May 23 2018 at 17:57)</a>:</h4>
<p>actually <span class="user-mention" data-user-id="116266">@Santiago Pastorino</span> asking for help to diagnose this ICE might be cruel and unusual punishment</p>



<a name="126988231"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/removing-locations-all/near/126988231" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/removing-locations-all.html#126988231">(May 23 2018 at 17:57)</a>:</h4>
<p>I think I sorta see the problem</p>



<a name="126988235"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/removing-locations-all/near/126988235" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/removing-locations-all.html#126988235">(May 23 2018 at 17:57)</a>:</h4>
<p>looking again with fresh eyes</p>



<a name="126988239"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/removing-locations-all/near/126988239" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/removing-locations-all.html#126988239">(May 23 2018 at 17:57)</a>:</h4>
<p>not 100% sure how to fix yet though</p>



<a name="126988240"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/removing-locations-all/near/126988240" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/removing-locations-all.html#126988240">(May 23 2018 at 17:57)</a>:</h4>
<p>I should probably re-run to generate the issue-42780 and clap facts</p>



<a name="126988939"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/removing-locations-all/near/126988939" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/removing-locations-all.html#126988939">(May 23 2018 at 18:10)</a>:</h4>
<p>ok</p>



<a name="126988982"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/removing-locations-all/near/126988982" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/removing-locations-all.html#126988982">(May 23 2018 at 18:10)</a>:</h4>
<p>I'm all ears anyway :)</p>



<a name="126989109"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/removing-locations-all/near/126989109" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/removing-locations-all.html#126989109">(May 23 2018 at 18:13)</a>:</h4>
<p>ok :) I'd say for now if you have time and feel like hacking the diagnostics stuff is good ... I'll figure this damn thing out ...</p>



<a name="126989200"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/removing-locations-all/near/126989200" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/removing-locations-all.html#126989200">(May 23 2018 at 18:15)</a>:</h4>
<p>ok</p>



<a name="126989209"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/removing-locations-all/near/126989209" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/removing-locations-all.html#126989209">(May 23 2018 at 18:15)</a>:</h4>
<p>I'm going to focus on diagnostics stuff and then ping the rest about rustc and polonius integration</p>



<a name="127005873"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/removing-locations-all/near/127005873" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/removing-locations-all.html#127005873">(May 24 2018 at 00:40)</a>:</h4>
<p>curious. I regenerated the facts using that branch — which means far fewer outlives facts, among other things — and found that overall the analysis ran slightly slower (e.g., 7.2s instead of 6.5s for <code>DatafromOpt</code> on clap). I have no idea why that would be.</p>



<a name="127005888"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/removing-locations-all/near/127005888" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/removing-locations-all.html#127005888">(May 24 2018 at 00:41)</a>:</h4>
<div class="codehilite"><pre><span></span>&gt; git show --stat 65d091795b
commit 65d091795b43467a1a789ecca259c120c42528de
Author: Niko Matsakis &lt;niko@alum.mit.edu&gt;
Date:   Wed May 23 15:32:56 2018 -0400

    regenerate facts without `Location::All`

 .../clap-rs/app-parser-{{impl}}-add_defaults/invalidates.facts  |  62166 ----
 inputs/clap-rs/app-parser-{{impl}}-add_defaults/outlives.facts  | 490010 -------------------------
 .../app-parser-{{impl}}-add_defaults/region_live_at.facts       | 294012 +++++++++++++++
 inputs/issue-47680/nll-facts/main/region_live_at.facts          |    116 +
 inputs/issue-47680/nll-facts/main/universal_region.facts        |      2 -
 inputs/issue-47680/nll-facts/{{impl}}-maybe_next/outlives.facts |     12 -
 .../nll-facts/{{impl}}-maybe_next/region_live_at.facts          |     14 +
 .../nll-facts/{{impl}}-maybe_next/universal_region.facts        |      3 -
</pre></div>



<a name="127005929"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/removing-locations-all/near/127005929" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/removing-locations-all.html#127005929">(May 24 2018 at 00:42)</a>:</h4>
<p>but the <code>region_live_at</code> facts were being added as a pre-processing step anyway...</p>



<a name="127005938"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/removing-locations-all/near/127005938" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/removing-locations-all.html#127005938">(May 24 2018 at 00:42)</a>:</h4>
<p>(I also don't know why the set of <code>invalidates</code> facts changed)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>